Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: move slower tests into pummel and skip on slow devices
Browse files Browse the repository at this point in the history
Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: nodejs#34289 (comment)
Trott committed Apr 25, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent d9b56fe commit 06498fb
Showing 5 changed files with 38 additions and 5 deletions.
12 changes: 10 additions & 2 deletions test/pummel/test-fs-watch-system-limit.js
Original file line number Diff line number Diff line change
@@ -5,10 +5,18 @@ const child_process = require('child_process');
const fs = require('fs');
const stream = require('stream');

if (!common.isLinux)
if (!common.isLinux) {
common.skip('The fs watch limit is OS-dependent');
if (!common.enoughTestCpu)
}

if (!common.enoughTestCpu) {
common.skip('This test is resource-intensive');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

try {
// Ensure inotify limit is low enough for the test to actually exercise the
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
'use strict';

require('../common');
const common = require('../common');

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const { spawnSync } = require('child_process');
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
'use strict';

const common = require('../common');

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const { spawnSync } = require('child_process');
Original file line number Diff line number Diff line change
@@ -2,8 +2,15 @@
'use strict';

const common = require('../common');
if (process.config.variables.asan)

if (process.config.variables.asan) {
common.skip('ASAN messes with memory measurements');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const assert = require('assert');
const net = require('net');
Original file line number Diff line number Diff line change
@@ -2,8 +2,14 @@

const common = require('../common');

if (!common.hasCrypto)
if (!common.hasCrypto) {
common.skip('missing crypto');
}

if ((process.config.variables.arm_version === '6') ||
(process.config.variables.arm_version === '7')) {
common.skip('Too slow for armv6 and armv7 bots');
}

const assert = require('assert');
const { subtle } = require('crypto').webcrypto;

0 comments on commit 06498fb

Please sign in to comment.