Skip to content

Commit

Permalink
build: lint commit message in separate Travis job
Browse files Browse the repository at this point in the history
Move the first commit message linting to a separate Travis job. Run the
script in bash debug mode to capture any issues communicating with the
GitHub API (e.g. network issues, rate limits).

PR-URL: nodejs#24254
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
  • Loading branch information
richardlau authored and Trott committed Nov 11, 2018
1 parent b5420c9 commit 19e5e78
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,21 @@ cache: ccache
os: linux
matrix:
include:
- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"
if: type = pull_request
language: node_js
node_js: "node"
script:
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST};
fi
- name: "Linter"
language: node_js
node_js: "node"
env:
- NODE=$(which node)
script:
- make lint
# Lint the first commit in the PR.
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
bash tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST} || true;
fi
- name: "Test Suite"
addons:
apt:
Expand Down

0 comments on commit 19e5e78

Please sign in to comment.