Skip to content

Commit

Permalink
build: run lint before tests
Browse files Browse the repository at this point in the history
Have `make test` run linting tools before tests rather than after. Lint
is likely to find issues quickly. Tests may take a while to run. So do
the linting first.

Interestingly, it appears that `vcbuild.bat` is already set up this way
on Windows.

Refs: nodejs#4546 (comment)
  • Loading branch information
Trott committed Feb 28, 2016
1 parent ffdc046 commit 86167c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ v8:
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)

test: | cctest # Depends on 'all'.
$(PYTHON) tools/test.py --mode=release message parallel sequential -J
$(MAKE) jslint
$(MAKE) cpplint
$(PYTHON) tools/test.py --mode=release message parallel sequential -J

test-parallel: all
$(PYTHON) tools/test.py --mode=release parallel -J
Expand Down

0 comments on commit 86167c2

Please sign in to comment.