fix: check missing config in Session ctor (nodejs#426)

Trott · May 30, 2020 · 7dc544d · 7dc544d
1 parent 75abd3a
commit 7dc544d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/components/git/land.js b/components/git/land.js
@@ -129,9 +129,7 @@ module.exports = {
 
 async function main(state, argv, cli, req, dir) {
   let session = new LandingSession(cli, req, dir);
-  if (session.warnForMissing()) {
-    return;
-  }
+
   if (state !== AMEND && state !== CONTINUE && session.warnForWrongBranch()) {
     return;
   }

diff --git a/lib/session.js b/lib/session.js
@@ -25,6 +25,10 @@ class Session {
 
     const { upstream, owner, repo } = this;
 
+    if (this.warnForMissing()) {
+      throw new Error('Failed to create new session');
+    }
+
     const upstreamHref = runSync('git', [
       'config', '--get',
       `remote.${upstream}.url`]).trim();

diff --git a/lib/sync_session.js b/lib/sync_session.js
@@ -9,9 +9,6 @@ class SyncSession extends Session {
   }
 
   async sync() {
-    if (this.warnForMissing()) {
-      return;
-    }
     if (this.warnForWrongBranch()) {
       return;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,9 +9,6 @@ class SyncSession extends Session { @@
       }
       async sync() {
-        if (this.warnForMissing()) {
-          return;
-        }
         if (this.warnForWrongBranch()) {
           return;
         }
@@ Expand Down @@