fix: consolidate replacement chars from extend() (#267)

Refs: simov/slugify#144 Refs: simov/slugify#145
Trott · Dec 13, 2021 · df7a488 · df7a488
1 parent dff8b2f
commit df7a488
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/slug.js b/slug.js
@@ -193,7 +193,7 @@
         if (localeMap[char]) {
           char = localeMap[char]
         } else if (opts.charmap[char]) {
-          char = opts.charmap[char]
+          char = opts.charmap[char].replace(opts.replacement, ' ')
         } else if (char.includes(opts.replacement)) {
           // preserve the replacement character in case it is excluded by disallowedChars
           char = char.replace(opts.replacement, ' ')

diff --git a/test/slug.test.js b/test/slug.test.js
@@ -952,6 +952,13 @@ describe('slug', function () {
     assert.strictEqual(slug('फ़'), 'fhqwhgads')
   })
 
+  it('consolidates repeated replacement characters from extend()', function () {
+    // https://github.com/simov/slugify/issues/144
+    assert.strictEqual(slug('day + night'), 'day-night')
+    slug.extend({ '+': '-' })
+    assert.strictEqual(slug('day + night'), 'day-night')
+  })
+
   it('should ignore symbols if they are not in the charmap', function () {
     assert.strictEqual(slug('unicode ♥ is ☢'), 'unicode-is')
   })