This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
SELA-301 Support Mocha without Karma as a test runner. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threehams
force-pushed
the
feature/SELA-301
branch
from
b238d1b
to
92bfa56
Compare
| // override to run tests in Node without Karma/Webpack | ||
| if (options.mochaOnly) { | ||
| const helperPath = path.join(__dirname, "..", "lib", "testHelperMocha.js"); | ||
| const testPath = `${CWD}/test/**/*.js`; |
There was a problem hiding this comment.
If we want to be consistent with our karma test helper, we'd use *.test.js as opposed to *.js at the end here: https://github.com/TrueCar/gluestick/blob/develop/src/lib/testHelper.js#L11
threehams
force-pushed
the
feature/SELA-301
branch
from
9a7283f
to
5cc54f8
Compare
threehams
changed the title
threehams
force-pushed
the
feature/SELA-301
branch
from
b9255ca
to
342a368
Compare
Filter to only run .test.js files. Add lots of comments around the wackier bits.
threehams
force-pushed
the
feature/SELA-301
branch
from
342a368
to
c75355a
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up Mocha to run tests without needing to spin up a browser or bundle. This is very close to a drop-in replacement right now.
Changes
require.extensionsonly works for file imports, not for modules, and anything without a relative path is assumed to be a module. This means that anything using a path such asimport ribbonUrl from "assets/img/icons/ribbon.svg"will pass in the Karma tests, and work in the app, but fail tests using Mocha.I'm trying to find a way to get this working, but the directory aliasing is done through Webpack, and is not based on any standard.
Benchmarks
Mocha + Karma + Webpack
Startup time: 43 seconds
Time from file save to results: 10-11 seconds
Mocha + Node
Startup time: 4 seconds
Time from file save to results: 400-800 ms