This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
Better support for api proxy #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version of `gluestick-shared` when you made a request to "/api" without a base URL, node had no idea what the actual URL to request was. 0.3.9 resolves this by setting baseURL on http clients that are set up with a request object. We were also setting `changeOrigin:true` on the dev mode proxy. This was making it so that the HTTP_HOST that the server would get would be localhost:8880 instead of the url that you are hitting with. Now the proper HTTP_HOST will be sent through
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of
gluestick-sharedwhen you made a request to"/api" without a base URL, node had no idea what the actual URL to
request was. 0.3.9 resolves this by setting baseURL on http clients that
are set up with a request object.
We were also setting
changeOrigin:trueon the dev mode proxy. This wasmaking it so that the HTTP_HOST that the server would get would be
localhost:8880 instead of the url that you are hitting with. Now the
proper HTTP_HOST will be sent through