This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
Resolve Dockerfile issue and pm2 error #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RUN gluestick build` was added to the wrong file `templates/new/src/config/.Dockerfile` which is actually overwritten at runtime by `docker/generate-dockerfile.js`. This commit will resolve that. There were instances where pm2 would throw an error if it tried to stop an instance that it knew nothing about. For some reason this error condition wasn't always repeatable. A simple try/catch was added so that PM2 will still start up even if it fails to run the stop command.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUN gluestick buildwas added to the wrong filetemplates/new/src/config/.Dockerfilewhich is actually overwritten atruntime by
docker/generate-dockerfile.js. This commit will resolvethat.
There were instances where pm2 would throw an error if it tried to stop
an instance that it knew nothing about. For some reason this error
condition wasn't always repeatable. To resolve the issue I added a function that will return whether or not an instance for a given name exists and then use that to determine if we should attempt to stop or delete.