Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language selector #10

Closed
simison opened this issue Oct 2, 2014 · 1 comment
Closed

Language selector #10

simison opened this issue Oct 2, 2014 · 1 comment
Assignees
@aurimus

Comments

@simison
Copy link
Contributor

simison commented Oct 2, 2014

Generic language selector (first to be used with Profiles).

  • Directive which adds Select2 to the page
  • Checks if languages.json was already loaded to browser memory and loads it if not
  • Possible to determine which model in surrounding controller directive is directing (imagine we'd want to edit profile.languages and searchQuery.languages with the same directive)
  • Returns array of language codes, eg. ['en', 'fi', 'lt']
  • If Model already had languages, show them in the Select2 with their names

Another directive for printing language list

  • Loads the same json into browser memory (shared, if it's already there, don't load it again)
@simison simison mentioned this issue Oct 2, 2014
Closed
11 tasks
aurimus added a commit that referenced this issue Oct 7, 2014
@aurimus
#10 Add angular-ui selec2 to configuration
2b4d9bc
aurimus added a commit that referenced this issue Oct 7, 2014
@aurimus
Add language service #10
dc29741
simison pushed a commit that referenced this issue Oct 7, 2014
@amoshaviv
Merge pull request #10 from fyockm/master
c054ec8 
ensure NODE_ENV is valid and default regex for walk
aurimus added a commit that referenced this issue Oct 8, 2014
@aurimus
Add working language selector that uses nodejs require and loads lang…
2d39fea 
…uages to template #10
aurimus added a commit that referenced this issue Oct 8, 2014
@aurimus
Make performance improvement and refactoring by reducing language fil…
2d25339 
…e size #10

Move language reading to a service #10
aurimus added a commit that referenced this issue Oct 8, 2014
@aurimus
Resolve merge conflict by only adding the new language service #10
e4b499a
@simison
Copy link
Contributor Author

simison commented Oct 8, 2014

👍 Nice and simple!

@simison simison closed this as completed Oct 8, 2014
simison added a commit that referenced this issue Oct 9, 2014
@simison
#10 Making JSHint happy
5071184 
…I know;
aurimus added a commit that referenced this issue Oct 9, 2014
@aurimus
Make corrections to language display #10
1985ed7 
1. display profile languages instead of currently logged in user
2. hide languages div when there are no languages
3. Reduce the list of languages by removing the historical languages
4. Make convert.rb
simison added a commit that referenced this issue Mar 22, 2015
@simison
#10 #206 Tiny optimizations in language factory
c6fdd53
simison added a commit that referenced this issue Mar 31, 2015
@simison
#10 #206 Change library powering language selector
58d0a34 
Switch from Angular-Select2 to Angular-Chosen for better performance.
mrkvon pushed a commit that referenced this issue Jan 16, 2024
@chmac
Merge pull request #10 from trustrootsops/renovate/moment-2.x
4566110 
Update dependency moment to v2.29.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aurimus aurimus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simison @aurimus