Profile avatar

[simison]

• Show Gravatar
• Show Facebook profile pic
• Upload your own
• Choose which one to show (default to Gravatar)

[simison]

Uploading your own avatar seems to be top1 feature request. Tackling it asap.

[Remigr]

If you use a third party blocker like disconnect, it will block facebook connection, and you cannot see any facebook avatar. On a profile page with a facebook avatar you will just see the default avatar picture. On the contact list nothing.
Should it be possible for the people who use facebook to upload there picture from facebook to trustroots ? Is it possible ?

[simison]

@Remigr It's a nice thought, but then it's not soo critical to see a photo. Upload FB photo -feature would add into complexity of already overly complex avatar selector.

What I can think of is automatic caching of Gravatar+FB. That might help to make site wee bit faster even. Just then we'd run into trouble with updating the photos when they change. On the other this is to fix a problem that occurs with very very small minority, while there are way more important things to tackle.

[guaka]

We should simply serve the FB image from our server

sent from my tablet
On Dec 30, 2014 11:54 AM, "Rémi Claude" notifications@github.com wrote:

If you use a third blocker like disconnect, it will block facebook
connection, and you cannot see any facebook avatar. On a profile page with
a facebook avatar you will just see the default avatar picture. On the
contact list nothing.
Should it be possible for the people who use facebook to upload there
pictre from facebook to trustroots ? Is it possible ?

—
Reply to this email directly or view it on GitHub
#7 (comment).

[Remigr]

Maybe it's a very small minority but if I go to https://www.trustroots.org/#!/privacy I can read "To opt-out of all tracking (including Google Analytics and Piwik) you can install Ghostery, Noscript or Disconnect." Even if it's not an urgent problem, it's a bit hypocrite to write this and not take the one who use blocker in consideration.
Serving FB image from server would be the best.

[roberts-gh]

+1. Yes, cache/copy the Gravatar or FB image, to the TR server. MK, are you still going to allow a way for us to simply upload a stand-alone image/avatar, too? How about pictures/gallery?

Agree with what Remi just said, too. I use several of the privacy/blocker plugins myself, on every browser/OS. It was keeping from seeing any Gravatar image, a detail I had forgotten about, which caused me a bit of confusion recently.

[simison]

@Remigr A valid point!
So: gravatar/fbtar goes trough backend —> it caches it for a week/day and eventually grabs new version —> served from our server —> if user edits profile/opens avatar editor, new version is pulled right away.
I'll create a todo later, but again I recon this is more of post march stuff? Ticket: #145

[simison]

@roberts-gh 👍 for uploads. See my comment above #7 (comment) :-)

[roberts-gh]

Thanks, MK, you're a coding machine! Much respect and gratitude to you!

[simison]

(Just trying not to add any new features before old ones are more or less fixed.)

[simison]

At master branch there's now uploading avatar -feature. Grande merci schön for monsieur @Remigr! Please, some testing for this would be awesome! (@guaka)

You'll need to migrate your DB, install some new dependencies etc. You can just run sh ./scripts/update.sh.

For me migrate command didn't work (on OSX) right away. I had to have that package globally installed: npm install -g migrate. Then run migrate again. Read more from troubleshooting ("my database is not up to date...")

Will push to production in a ~week or so after some heavy testing.

[roberts-gh]

Thanks @Remigr !

[guaka]

testing this on dev.trustroots.org, here's what happens:

• I get an image not found (without any image)
• I go to https://dev.trustroots.org/#!/profile/guakatest/edit
• upload .jpg
• new image not showing up
• refresh gives error:

 Error: Error setting TTL index on collection : sessions
    at /srv/trustroots/node_modules/connect-mongo/lib/connect-mongo.js:169:23
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1459:28
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1605:30
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/cursor.js:169:22
    at Cursor.nextObject (/srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/cursor.js:744:16)
    at Cursor.toArray (/srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/cursor.js:168:10)
    at fallbackListIndexes (/srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1604:65)
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1615:20
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1153:22
    at /srv/trustroots/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1890:9

• now image still is set on Gravatar (which doesn't exist for the email address I use here)

[simison]

Aha, yea so it does crash at some point. Might be any of these or something else:

• Perhaps dev DB isn't migrated for the feature yet, or migration script failed at something
• Folder lacking write access
• Folder doesn't exist
• Some NPM package not functioning

(TTL error is due mongo not being up while the Node app is already running, I need to copy a fix for that from mean.js master but it's unrelated.)

Sorry I haven't yet got time to check this in detail & push to production, but soon soon. :-)