Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Bookmark card issue #1478

Closed
wants to merge 5 commits into from
Closed

Conversation

devaman
Copy link
Contributor

@devaman devaman commented Jan 26, 2020

Bookmark card: Better url handling and error message resolves

refs/closes #11212

  • Better error message handling
  • Storing original url on payload
  • Fixing empty payload for invalid cases:

Check Ghost Admin pull request for Bookmark card issue also. Both of them together resolves this issue.

kevinansfield added a commit that referenced this pull request Jun 8, 2020
refs TryGhost/Ghost#11212
credit @devaman #1478

- display the original url rather than the fetched url in order to preserve query params and redirects (useful for affiliate links)
@kevinansfield
Copy link
Member

Thank you for the PR! These changes were cleaned up and introduced in the following commits:

TryGhost/Ghost@db68560
17cb3ec

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants