This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Dispatch event to root only if the key combo is registered as shortcut #1739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TryGhost/Ghost#12294.
Cache registered shortcuts and check KeyboardEvent before dispatching event to the root.
Fixed the bug introduced with #1707.
I wish there were a way to test ctrl+v event. But unfortunately, native events are not executed by triggering event in the acceptance tests.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
ember test
from the repo root - will becore/client
if working from the submodule in Ghost).More info can be found by clicking the "guidelines for contributing" link above.