fix(resolve-version): sort versions before retrieving latest (#939)

TryGhost · May 29, 2019 · 8a17c8b · 8a17c8b
1 parent f479cf1
commit 8a17c8b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/utils/resolve-version.js b/lib/utils/resolve-version.js
@@ -43,7 +43,7 @@ module.exports = function resolveVersion(version, activeVersion, v1 = false, for
     }
 
     return packageInfo('ghost', {allVersions: true}).then((result) => {
-        const versions = Object.keys(result.versions).filter(v => semver.satisfies(v, comparator));
+        const versions = Object.keys(result.versions).filter(v => semver.satisfies(v, comparator)).sort(semver.compare);
 
         if (!versions.length) {
             return Promise.reject(new errors.CliError({

diff --git a/test/unit/utils/resolve-version-spec.js b/test/unit/utils/resolve-version-spec.js
@@ -90,6 +90,12 @@ describe('Unit: resolveVersion', function () {
                 expect(version).to.equal('1.52.37');
             });
         });
+
+        it('resolves with latest version if 1.x release is newer than latest 2.x', async function () {
+            const resolveVersion = stub(['1.0.0', '1.0.1', '2.0.0', '2.0.1', '1.0.2']);
+            const version = await resolveVersion();
+            expect(version).to.equal('2.0.1');
+        });
     });
 
     describe('with existing version', function () {