Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory availability check #1185

Closed
PaszaVonPomiot opened this issue May 4, 2020 · 4 comments · Fixed by #1209
Closed

Memory availability check #1185

PaszaVonPomiot opened this issue May 4, 2020 · 4 comments · Fixed by #1209

Comments

@PaszaVonPomiot
Copy link

Summary

When trying to update ghost i get:
You are recommended to have at least 150 MB of memory available for smooth operation. It looks like you have ~140 MB available
And it seems it doesn't take into account swap because mine is fully available:

$ free -h
              total        used        free      shared  buff/cache   available
Mem:           985M        640M         97M         12M        248M        178M
Swap:          1.9G        188M        1.7G

Steps to Reproduce

  • sudo npm install -g npm
  • sudo npm install ghost-cli@latest -g
  • ghost update

Log file

1) SystemError

Message: You are recommended to have at least 150 MB of memory available for smooth operation. It looks like you have ~140 MB available.

Debug Information:
    OS: Ubuntu, v18.04.3 LTS
    Node Version: v10.17.0
    Ghost Version: 2.28.0
    Ghost-CLI Version: 1.13.1
    Environment: production
    Command: 'ghost update'
@oskarkrawczyk
Copy link

I do wonder if there's a specific reason why only available hardware memory is checked.

systeminformation itself provides info about available swap, so there must have been a reason not to utilize that information.

@acburdine
Copy link
Member

@PaszaVonPomiot @oskarkrawczyk that may have just been an oversight when we added systeminformation - I'll look and see if we can update that check to include free swap as well

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 2, 2020
closes TryGhost#1185
- add swapfree to available to get estimated memory availability
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 2, 2020
closes TryGhost#1185
- add swapfree to available to get estimated memory availability
acburdine added a commit that referenced this issue Jun 2, 2020
closes #1185
- add swapfree to available to get estimated memory availability
@oskarkrawczyk
Copy link

@acburdine you're the man! Thank you for this!

@acburdine
Copy link
Member

Fix released in Ghost-CLI 1.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants