Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor task list to only show one task at a time #181

Closed
acburdine opened this issue Mar 21, 2017 · 0 comments · Fixed by #235
Closed

Refactor task list to only show one task at a time #181

acburdine opened this issue Mar 21, 2017 · 0 comments · Fixed by #235
Assignees

Comments

@acburdine
Copy link
Member

acburdine commented Mar 21, 2017

After the ES6 refactor, the most complex CLI commands were refactored to use listr - a pretty awesome module for rendering task lists with statuses, as well as cleaning up a lot of the promise chaining behavior.

However, the current rendering module it uses by default (this one) can have UX issues when on a slow terminal connection (e.g. SSH connections to servers overseas). Basically because it renders (and re-renders) the entire task list every cycle, it can sometimes appear to be "flashing", e.g. noticeably disappearing and then reappearing, which isn't super great for UX.

I will open an issue on the relevant repository to see if there's willingness to implement this as a custom option; however if not then it will need to be manually implemented here.

Could be important, because of prompts to the user!

@acburdine acburdine self-assigned this Jun 26, 2017
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 26, 2017
closes TryGhost#181
- add custom Listr renderer that works better with other UI methods e.g. log, prompt, run
- refactor commands to use this.ui.listr instead of new Listr()
- fix various command arg bugs
acburdine added a commit that referenced this issue Jun 26, 2017
closes #181
- add custom Listr renderer that works better with other UI methods e.g. log, prompt, run
- refactor commands to use this.ui.listr instead of new Listr()
- fix various command arg bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants