-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx config client_max_body_size #231
Comments
Something that might be possible to add to the nginx configuration setup is something with command args - e.g. Since yargs doesn't throw on extraneous args we should be able to do something like this for various nginx rules. |
Not sure I follow what you mean? This isn't a custom config that I want, but something that most people would need. The default is 1mb, which isn't really big enough to do any sort of image upload 😁 |
Apologies - should have made that a bit more clear 😬 Definitely agree with adding the max_body_size config rule. The command line args thing would work for other use-cases of adding special rules on a per-conf bases. |
I have referenced this issue in the improvements section in #216. |
closes TryGhost#231 Adds `client_max_body_size 50m;` to nginx config file.
closes TryGhost#231 Adds `client_max_body_size 50m;` to nginx default config file.
closes TryGhost#231 Adds `client_max_body_size 50m;` to nginx default config file.
closes #231 Adds `client_max_body_size 50m;` to nginx default config file.
Nginx defaults to a max body size of 1mb, which isn't great for image and theme uploads.
I have been adding
client_max_body_size 50m;
as part of the install process for nginx before running ghost-cli.On a fresh nginx install, I do this by adding the line after
types_hash_max_size 2048;
in /etc/nginx/nginx.conf. Ansible has a lovely tool called "lineinfile" that I wonder if we can reproduce?I wonder if we should either document this, or get ghost-cli to attempt to set it?
The text was updated successfully, but these errors were encountered: