Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging output #42

Closed
kirrg001 opened this issue Sep 27, 2016 · 3 comments · Fixed by #172
Closed

Improve logging output #42

kirrg001 opened this issue Sep 27, 2016 · 3 comments · Fixed by #172

Comments

@kirrg001
Copy link
Contributor

Right now ghost-cli starts development mode and production mode in background by spawning a child process.

I am working on logging for ghost and i wonder how this can look like with ghost-cli.
We can create a command like ghost log, which is aware of where the log rotated files are and makes a tail of the newest file. Not sure about development mode, because usually we log in development to stdout/stderr only. That would mean ghost start name=development would not start the process in background and pipes the stdout/stderr to current process.

@acburdine
Copy link
Member

So the design of the CLI is that each process manager is responsible for starting and spawning its own ghost process, which includes managing logs and other things. (kind of works similar to the storage adapters in ghost itself).

My thought here is to add better logging output to the local process manager and then possibly a ghost log command that also integrates with the process manager to return the log.

As far as logging directly to stdout/stderr in development mode, that's probably best left to the process managers themselves - might be willing to add that to the local process manager but thinking about it it might not be within the scope of the CLI. IMO Ghost-CLI should be used to install ghost for production or locally for development of themes/apps/adapters/etc, but if Ghost core itself is actuallly being worked on the CLI shouldn't be used to install it.

@acburdine acburdine changed the title logging Improve logging output Sep 27, 2016
@ErisDS
Copy link
Member

ErisDS commented Sep 27, 2016

IMO ghost install will always use production mode, and ghost install local will do a simpler install for development mode using the local process manager.

The intended use for ghost install local is theme & app development, so whatever logging solution is designed should consider this usecase - what to theme / app developers need?

I think they will want to be able to view any error output they generate whilst developing?

@acburdine
Copy link
Member

This will also likely be addressed by #66

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 16, 2017
closes TryGhost#42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.9 (used for the PrettyStream)
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 16, 2017
closes TryGhost#42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.9 (used for the PrettyStream)
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 16, 2017
closes TryGhost#42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.9 (used for the PrettyStream)
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 16, 2017
closes TryGhost#42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.9 (used for the PrettyStream)
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Mar 16, 2017
closes TryGhost#42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.10 (used for the PrettyStream)
acburdine added a commit that referenced this issue Mar 16, 2017
closes #42
- read bunyan log outputted by ghost
- deps: slice-file@1.0.0
- deps: ghost-ignition@2.8.10 (used for the PrettyStream)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants