Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodemailer "sendmail" transport is case sensitive: change in behavior #421

Closed
lexpierce opened this issue Aug 2, 2017 · 0 comments · Fixed by #424
Closed

Nodemailer "sendmail" transport is case sensitive: change in behavior #421

lexpierce opened this issue Aug 2, 2017 · 0 comments · Fixed by #424
Assignees

Comments

@lexpierce
Copy link

https://github.com/nodemailer/nodemailer/tree/0.7#setting-up-sendmail

As you can see, they use an all lowercase "sendmail" in the definition. I have used this for all my ghost installs until I moved to 1.0.0 release (1.0.3 specifically). Apparently Ghost-CLI now does validation that expects "Sendmail" and rejects "sendmail". There is nothing on the nodemailer github page that dictates case, and "sendmail" worked with older ghost, other nodemailer instances I have used, and all of the alpha/beta/RC instances of Ghost I ran (pre 1.0 Ghost-CLI).

Looking at https://github.com/nodemailer/nodemailer/blob/0.7/lib/transport.js they use toUpper to compare transport settings anyway.

@ErisDS ErisDS self-assigned this Aug 3, 2017
ErisDS added a commit to ErisDS/Ghost-CLI that referenced this issue Aug 3, 2017
closes TryGhost#421

- uses toLowerCase() and lists all config options in lowercase
acburdine pushed a commit that referenced this issue Aug 5, 2017
closes #421

- uses toLowerCase() and lists all config options in lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants