New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): rename force flag to 'check-empty' #1237

Merged

acburdine merged 1 commit into TryGhost:master from acburdine:fix/install-force-flag-rename

Jun 28, 2020

Member

acburdine commented Jun 28, 2020

closes #1218


          fix(install): rename force flag to 'check-empty'

3e715dd

acburdine merged commit 6281eaa into TryGhost:master

acburdine deleted the fix/install-force-flag-rename branch

June 28, 2020 13:40

vikaspotluri123 reviewed

View reviewed changes

lib/commands/install.js

    
            @@ -23,7 +23,7 @@ class InstallCommand extends Command {
          
                      let version = argv.version ? `${argv.version}` : null;

                      // Check if the directory is empty

                      if (!dirIsEmpty(process.cwd()) && !argv.force) {

                      if (!dirIsEmpty(process.cwd()) && argv['check-empty']) {

Member

vikaspotluri123 Jun 28, 2020

We could have a minor perf improvement by swapping these checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet