Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): remind user to restart ghost after making changes #1382

Merged
merged 1 commit into from
Jan 28, 2021
Merged

feat(config): remind user to restart ghost after making changes #1382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/commands/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ class ConfigCommand extends Command {
// setter
this.instance.config.set(key, value).save();
this.ui.log(`Successfully set '${key}' to '${value}'`, 'green');

// If the instance is running, we want to remind the user to restart
// it so the new config can take effect. The isRunning check is only
// a nicety, so if it fails, swallow the error for better UX.
try {
if (await this.instance.isRunning()) {
const chalk = require('chalk');
this.ui.log(
`Ghost is running. Don't forget to run ${chalk.cyan('ghost restart')} to reload the config!`
);
}
} catch (_) {} // eslint-disable-line no-empty

return;
}

Expand Down