Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): disallow running internal stages from command line flags #1596

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

vikaspotluri123
Copy link
Member

@vikaspotluri123 vikaspotluri123 commented Jan 29, 2022

no issue

This was discovered in the forum. Internal steps shouldn't be able to be picked via command line flags (e.g. ghost setup instance nginx), so this PR fixes that.

@acburdine acburdine merged commit 758c84f into TryGhost:1.x Jan 31, 2022
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve before merging 🙃 LGTM

@vikaspotluri123 vikaspotluri123 changed the title fix(deprecation): fix error with missing instance version fix(setup): disallow running internal stages from command line flags Jan 31, 2022
@vikaspotluri123 vikaspotluri123 deleted the no-internal-setup branch January 31, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants