fix(root-user): show different error message for 1-click installs #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
reviewed
Feb 7, 2018
lib/utils/check-root-user.js
Outdated
| // We have a Digitalocean one click installation | ||
| console.error(`${chalk.yellow('We discovered that you are using the Digitalocean 1-click install.')} | ||
| You need to create a user with regular account privileges and migrate your installation to use this user. | ||
| Please follow the steps here ${chalk.underline.green('https://docs.ghost.org/docs/troubleshooting#section-fix-root-user')} to fix your setup.`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
force-pushed
the
root-user-message
branch
2 times, most recently
from
e55ba4e
to
4dc7d07
Compare
acburdine
requested changes
Feb 7, 2018
lib/utils/check-root-user.js
Outdated
| process.exit(1); | ||
| } | ||
|
|
||
| return; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/check-root-user.js
Outdated
|
|
||
| if (!includes(allowedCommands, command)) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/check-root-user.js
Outdated
| You need to create a user with regular account privileges and migrate your installation to use this user. | ||
| Please follow the steps here ${chalk.underline.green('https://docs.ghost.org/docs/troubleshooting#section-fix-root-user')} to fix your setup.`); | ||
| } else if (isRootInstall()) { | ||
| console.error(`${chalk.yellow('It seems installed Ghost as root user.')} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/check-root-user.js
Outdated
| // We have a Digitalocean one click installation | ||
| console.error(`${chalk.yellow('We discovered that you are using the Digitalocean One-Click install.')} | ||
| You need to create a user with regular account privileges and migrate your installation to use this user. | ||
| Please follow the steps here ${chalk.underline.green('https://docs.ghost.org/docs/troubleshooting#section-fix-root-user')} to fix your setup.`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/check-root-user.js
Outdated
| } else if (isRootInstall()) { | ||
| console.error(`${chalk.yellow('It seems installed Ghost as root user.')} | ||
| You need to create a user with regular account privileges and migrate your installation to use this user. | ||
| Please follow the steps here ${chalk.underline.green('https://docs.ghost.org/docs/troubleshooting#section-fix-root-user')} to fix your setup.`); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/check-root-user.js
Outdated
| if (os.platform() !== 'linux') { | ||
| const isRootInstall = function isRootInstall() { | ||
| const path = require('path'); | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
no issue - detect DigitalOcean One-Click install and render a message how to migrate their installation to a non-root user - detect root installs and render message to migrate their installation to a non-root user - allow ghost `start`, `stop` and `restart` to be executed as root without exiting, but showing the error message
aileen
force-pushed
the
root-user-message
branch
from
4dc7d07
to
b0bc7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue