fix(doctor): skip install dir checks for local installs #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
reviewed
May 7, 2018
| @@ -16,7 +16,9 @@ function installFolderPermissions(ctx) { | |||
| task: taskTitle | |||
| })); | |||
| }).then(() => { | |||
| if (ctx.local || !ctx.system.platform.linux || (ctx.argv && ctx.argv['setup-linux-user'] === false)) { | |||
| const isLocal = ctx.local || ctx.instance && ctx.instance.process.name === 'local'; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aileen
force-pushed
the
fix-folder-perm-check-start
branch
from
6fcb427
to
c96a8eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #711
We successfully pass this check for the
ghost install localcommand and the intention was to always pass/skip it for local installs. Thelocalargument is only available when executing the installation command. But this check also runs forghost startandghost updatewhen there's nolocalargument.This change will skip the check now also when the local process manager is used, which usually means that it's a local installation.