Added confirmation/support for automatically rolling back to previous version #773

vikaspotluri123 · 2018-08-02T02:49:31Z

The wording won't work because I want to rebase on #772 and #771 before finalizing how the function will work

lib/commands/update.js

+    rollbackFromFail(error, argv) {
+        const previousVersion = this.system.getInstance().cliConfig.get('previous-version');
+        this.ui.error(error);
+        const question = argv.version === '2.0.0' ?


lib/commands/update.js

+            }
+
+            return this.run({
+                rollback: true


lib/commands/update.js

@@ -179,6 +181,25 @@ class UpdateCommand extends Command {
        });
    }

+    rollbackFromFail(error, argv) {
+        const previousVersion = this.system.getInstance().cliConfig.get('previous-version');
+        this.ui.error(error);


vikaspotluri123 · 2018-08-06T12:06:40Z

@kirrg001 updated the error message, still not sure how we should handle the error

kirrg001 · 2018-08-06T21:13:38Z

@vikaspotluri123 I'll take a look at this PR tomorrow :) Will also look at the error handling.

vikaspotluri123 · 2018-08-07T03:16:13Z

Tests have been added!

coveralls · 2018-08-07T03:18:14Z

Coverage increased (+0.001%) to 99.831% when pulling a4b68ca on vikaspotluri123:ghost2/rollback-on-fail into 2f3de69 on TryGhost:1.9.

kirrg001 · 2018-08-07T11:35:08Z

I have to test two cases:

A: You want to migrate and an error occurs during the migration.
B: You have successfully migrated, but want to rollback.

kirrg001 · 2018-08-07T20:26:24Z

@vikaspotluri123 I'll take a look at this PR tomorrow :) Will also look at the error handling.

Tomorrow! 👻

lib/commands/update.js

+        const question = `Unable to upgrade Ghost from v${oldVer} to v${newVer}. Would you like to revert back to v${oldVer}?`;
+        const promise = force ? Promise.resolve(true) : this.ui.confirm(question, true);
+
+        this.ui.error(error);


lib/commands/update.js

+    rollbackFromFail(error, newVer, force = false) {
+        const oldVer = this.system.getInstance().cliConfig.get('previous-version');
+        const question = `Unable to upgrade Ghost from v${oldVer} to v${newVer}. Would you like to revert back to v${oldVer}?`;
+        const promise = force ? Promise.resolve(true) : this.ui.confirm(question, true);


lib/commands/update.js

@@ -114,7 +114,9 @@ class UpdateCommand extends Command {
                    return;
                }

-                return this.ui.listr(tasks, context);
+                return this.ui.listr(tasks, context).catch(error =>
+                    this.rollbackFromFail(error, context.version, argv['auto-rollback'])


lib/commands/update.js

+                return Promise.resolve();
+            }
+
+            return this.run({


lib/commands/update.js

@@ -195,6 +197,24 @@ class UpdateCommand extends Command {
        });
    }

+    rollbackFromFail(error, newVer, force = false) {


lib/commands/update.js

@@ -114,7 +114,9 @@ class UpdateCommand extends Command {
                    return;
                }

-                return this.ui.listr(tasks, context);


kirrg001 · 2018-08-08T10:37:42Z

I'll push changes in a bit.

refs TryGhost#759 - ask user if we wants to bring back previous version if - GhostError was thrown (migration failed) - if the user has not executed `ghost update --rollback` - show error to user so he knows why the update failed

refs TryGhost#759 - return a proper GhostError when migration fails - detect if knex-migrator can't find versions to rollback (resolve in this case)

…st v1 refs TryGhost#759

kirrg001 · 2018-08-08T10:53:14Z

I am doing a final test, then i'll merge this into 1.9.

kirrg001 changed the base branch from master to 1.9 August 2, 2018 07:24

kirrg001 force-pushed the 1.9 branch from 06bc19c to 9808328 Compare August 2, 2018 09:44

kirrg001 reviewed Aug 2, 2018

View reviewed changes

lib/commands/update.js Outdated

}

return this.run({

rollback: true

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

kirrg001 reviewed Aug 2, 2018

View reviewed changes

kirrg001 changed the title ~~feat(update): add support for automatically rolling back failed updates~~ [WIP] feat(update): add support for automatically rolling back failed updates Aug 3, 2018

vikaspotluri123 force-pushed the ghost2/rollback-on-fail branch from 1c818db to 3c73204 Compare August 6, 2018 12:05

vikaspotluri123 force-pushed the ghost2/rollback-on-fail branch 2 times, most recently from 35465d9 to 71d49f6 Compare August 7, 2018 03:15

kirrg001 force-pushed the ghost2/rollback-on-fail branch from 71d49f6 to 53e4ccf Compare August 8, 2018 08:41

kirrg001 reviewed Aug 8, 2018

View reviewed changes

lib/commands/update.js

return Promise.resolve();

}

return this.run({

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

kirrg001 reviewed Aug 8, 2018

View reviewed changes

lib/commands/update.js

@@ -195,6 +197,24 @@ class UpdateCommand extends Command {

});

}

rollbackFromFail(error, newVer, force = false) {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

kirrg001 reviewed Aug 8, 2018

View reviewed changes

lib/commands/update.js

@@ -114,7 +114,9 @@ class UpdateCommand extends Command {

return;

}

return this.ui.listr(tasks, context);

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

kirrg001 force-pushed the ghost2/rollback-on-fail branch from 59fba4f to 435ad4d Compare August 8, 2018 10:41

kirrg001 changed the title ~~[WIP] feat(update): add support for automatically rolling back failed updates~~ [WIP] Added support for automatically rolling back failed updates Aug 8, 2018

vikaspotluri123 and others added 3 commits August 8, 2018 12:51

Optimised error handling in migrator task

9f8127f

refs TryGhost#759 - return a proper GhostError when migration fails - detect if knex-migrator can't find versions to rollback (resolve in this case)

Fixed ghost update --force to jump to next major if you are on late…

a4b68ca

…st v1 refs TryGhost#759

kirrg001 force-pushed the ghost2/rollback-on-fail branch from 435ad4d to a4b68ca Compare August 8, 2018 10:52

kirrg001 changed the title ~~[WIP] Added support for automatically rolling back failed updates~~ Added support for automatically rolling back failed updates Aug 8, 2018

kirrg001 changed the title ~~Added support for automatically rolling back failed updates~~ Added confirmation/support for automatically rolling back to previous version Aug 8, 2018

kirrg001 merged commit 464d13a into TryGhost:1.9 Aug 8, 2018

vikaspotluri123 deleted the ghost2/rollback-on-fail branch August 16, 2018 02:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added confirmation/support for automatically rolling back to previous version #773

Added confirmation/support for automatically rolling back to previous version #773

vikaspotluri123 commented Aug 2, 2018 •

edited

Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

vikaspotluri123 commented Aug 6, 2018

kirrg001 commented Aug 6, 2018

vikaspotluri123 commented Aug 7, 2018

coveralls commented Aug 7, 2018 •

edited

Loading

kirrg001 commented Aug 7, 2018

kirrg001 commented Aug 7, 2018

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

kirrg001 commented Aug 8, 2018

kirrg001 commented Aug 8, 2018

Added confirmation/support for automatically rolling back to previous version #773

Added confirmation/support for automatically rolling back to previous version #773

Conversation

vikaspotluri123 commented Aug 2, 2018 • edited Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

vikaspotluri123 commented Aug 6, 2018

kirrg001 commented Aug 6, 2018

vikaspotluri123 commented Aug 7, 2018

coveralls commented Aug 7, 2018 • edited Loading

kirrg001 commented Aug 7, 2018

kirrg001 commented Aug 7, 2018

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

kirrg001 commented Aug 8, 2018

kirrg001 commented Aug 8, 2018

vikaspotluri123 commented Aug 2, 2018 •

edited

Loading

coveralls commented Aug 7, 2018 •

edited

Loading