Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ~/.config folder ownership check on CLI startup #825

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

acburdine
Copy link
Member

closes #675

this pr does two things:

  • adds a clearOnSuccess option to the renderer, for optional clearing of the spinner after successful completion
  • converts the update-check to a list task set, adding a ~/.config folder step to the pre-check.

- mimics the "clear" option in ui.run, but applies to all tasks
@coveralls
Copy link

coveralls commented Sep 17, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 5704a98 on acburdine:fix/configstore-ownership into 4621bcc on TryGhost:master.

}
})
}, {
title: 'Checking ~/.config folder ownership',

This comment was marked as abuse.

Copy link
Member

@vikaspotluri123 vikaspotluri123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise everything seems fine

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

closes TryGhost#675
- convert update check to a listr task set
- add ~/.config directory check to list of prechecks
@acburdine acburdine merged commit e9e640f into TryGhost:master Sep 17, 2018
@acburdine acburdine deleted the fix/configstore-ownership branch September 17, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost-CLI 1.5.2 fails in a loop
4 participants