Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add emojis with iPadOS Safari #11541

Closed
tonilampela opened this issue Jan 25, 2020 · 10 comments · Fixed by bustle/mobiledoc-kit#764
Closed

Unable to add emojis with iPadOS Safari #11541

tonilampela opened this issue Jan 25, 2020 · 10 comments · Fixed by bustle/mobiledoc-kit#764
Assignees
@daniellockyer
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@tonilampela
Copy link

Ghost version 3.3.0. When using editor with Safari of iPadOS 13.3 typing emojis results just mangled characters. On macOS Safari emojis work just fine.
5BCD0EA1-C91E-4FB3-AE7B-25736442C632
@naz naz added the affects:admin Anything relating to Ghost Admin label Feb 11, 2020
@ErisDS ErisDS added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor labels Apr 20, 2020
@stale
Copy link

stale bot commented Jul 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Jul 19, 2020
@stale stale bot closed this as completed Jul 26, 2020
@s00500
Copy link

s00500 commented Aug 8, 2022

This is neither stale nor fixed, I have the same issue on the latest 5.6.0

@s00500
Copy link

s00500 commented Aug 8, 2022

Is there anyway one can reopen this or do I have to create the same issue again ?

@ErisDS
Copy link
Member

ErisDS commented Aug 8, 2022

@s00500 I'm happy to reopen if you intend to work on it? 🙂

@s00500
Copy link

s00500 commented Aug 8, 2022

Hm I can take a look.... but if anybody has pointers it would be useful...

It seems to work just fine if I create the emoji in the ios notes app and then paste it over... could it be that ghosts editor truncates the second half of the unicode char when inserting? It is definitely a problem in the editor, display and storage work fine... and it really only happens on ios browsers

@ErisDS ErisDS removed the stale [triage] Issues that were closed to to lack of traction label Aug 8, 2022
@ErisDS ErisDS reopened this Aug 8, 2022
@ErisDS
Copy link
Member

ErisDS commented Aug 8, 2022

I've reopened the issue - but short of letting you know that the admin client lives in ghost/admin now I wouldn't know where to look for this issue. It may well be upstream in mobiledoc-kit maybe something similar to this bug.

Ghost doesn't officially support mobile editing at present - there's another thread where I explained this recently here.

Very very happy for people to get involved and help make the experience better though.

@s00500
Copy link

s00500 commented Aug 8, 2022

Thanks for reopening @ErisDS
And thanks for the pointers, as it seems it is indeed an upstream bug, as it has the same behavior when trying on the official demo of the editor lib here:

https://bustle.github.io/mobiledoc-kit/demo/

I might take a look into this next week....

Generally I can confirm that the ios editing experience is pretty good, there are some glitches here and there but nothing that lead to an unrecoverable situation

For now the workaround with pasting emojis from the notes app also seems to be a viable option in the shirt term

JBYoshi added a commit to JBYoshi/mobiledoc-kit that referenced this issue Aug 11, 2022
@JBYoshi
Fix emoji inputs.
d306ce0 
Emoji char codes are bigger than String.fromCharCode() supports. String.fromCodePoint() has a larger range.

Fixes TryGhost/Ghost#11541.
@JBYoshi JBYoshi mentioned this issue Aug 11, 2022
Merged
gpoitch added a commit to bustle/mobiledoc-kit that referenced this issue Aug 11, 2022
@JBYoshi @gpoitch
Fix emoji input on iOS (#764)
305b1a2 
* Fix emoji inputs.

Emoji char codes are bigger than String.fromCharCode() supports. String.fromCodePoint() has a larger range.

Fixes TryGhost/Ghost#11541.

* Add a unit test.

Co-authored-by: Garth Poitras <411908+gpoitch@users.noreply.github.com>
@JBYoshi
Copy link
Contributor

JBYoshi commented Aug 13, 2022

A fix has been added to mobiledoc-kit v0.14.1. This should be fixed whenever that gets pulled into Ghost.

@ErisDS
Copy link
Member

ErisDS commented Aug 15, 2022

Oh cool cc @daniellockyer our fork of mobiledoc-kit needs to pull in this patch: bustle/mobiledoc-kit@305b1a2

@daniellockyer daniellockyer self-assigned this Aug 16, 2022
daniellockyer added a commit that referenced this issue Aug 16, 2022
@daniellockyer
🐛 Fixed adding emojis in editor
d7aa064 
fixes #11541

- due to an upstream bug, typing emojis using Safari would show square
  boxes in the editor
- the upstream patch has been fixed, so I've pulled it into our
  mobiledoc-kit fork
- this commit bumps that package to fix the issue in Ghost
@daniellockyer
Copy link
Member

Hey all 👋🏻 I've backported the patch into our mobiledoc-kit fork and bumped it in Ghost. The fix will be available with the next Ghost release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniellockyer daniellockyer

Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix emoji input on iOS JBYoshi/mobiledoc-kit
6 participants
@ErisDS @naz @tonilampela @daniellockyer @s00500 @JBYoshi