Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable Permalinks #1395

Closed
ErisDS opened this issue Nov 4, 2013 · 8 comments
Closed

Customisable Permalinks #1395

ErisDS opened this issue Nov 4, 2013 · 8 comments
Assignees
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Nov 4, 2013

Ghost should be able to support the common

/year/month/day/title/

format, as well as the current flat

/title/

Other formats may be added, but making Ghost support 2 is a big enough task for one issue :)

For now, the UI to switch over should be a checkbox on the general settings screen.

@JohnONolan
Copy link
Member

Would it make sense to approach this more as "flexible permalinks" rather than "2 permalink structures" ? Eg. how wordpress allows you to make up your own /%post-title%/%year%/%hamster%/ if you want

(from an implementation pov)

@ErisDS
Copy link
Member Author

ErisDS commented Nov 4, 2013

Valid question, but it doesn't matter at this stage - we have no UI for this at the moment so might as well be a switch you can flip or a checkbox or whatever.

Point of this issue is to refactor Ghost such that the permalink structure is not baked in, then we can make a fancy way of specifying what the permalink should be as a further enhancement.

@jgillich
Copy link
Contributor

Should we leave this open to track the UI and live reloading stuff as well?

@ErisDS
Copy link
Member Author

ErisDS commented Nov 25, 2013

Yeah I think so :)

@ErisDS
Copy link
Member Author

ErisDS commented Dec 7, 2013

Is there anything more to do on this?

@jgillich
Copy link
Contributor

jgillich commented Dec 7, 2013

Just the UI.

@ErisDS
Copy link
Member Author

ErisDS commented Dec 7, 2013

Ok cool, I'll open #1631 instead 👍

@ErisDS ErisDS closed this as completed Dec 7, 2013
@hswolff
Copy link
Contributor

hswolff commented Jan 3, 2014

Leaving this here, link to express's path to regex function. We could use this when allowing for even greater permalink functionality.

https://github.com/visionmedia/express/blob/master/lib/utils.js#L156

from irc

[16:39:59] <hswolff> and then you can make a route of '/(.*)' and compare that against the current setting's permalink req.param[0].match(permalinkRegex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants