-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When date permalink is ticked, links to post do not work #1757
Comments
You'll have to restart Ghost. |
Mmm... I'd add a note next to the option then, something like: |
Hi @simonech, thanks for reporting this. You should not have to restart Ghost, so it seems you've found a bug. |
FYI I started work on fixing this last night. Should have something to show soon. |
closes TryGhost#1757 and TryGhost#1773 - switches routes.frontend for posts and pages to use a regex with two capturing groups. This removes the need to dynamically remove an express route at a later point, leaving the decision making to frontend controller. - added unit tests for all routing conditions that can arise for posts and pages. - updated functional tests to also test for same thing in unit tests - removes old code from server/api/index that used to fix this issue, but is no longer needed - removed some un-needed require statements in routes/admin
I know I'm a bit late, but why was it necessary to replace the dynamic permalink route with a regex that only allows the two current formats? We want to allow pretty much any format, so when #1631 is done I would have to revert this (?) |
There were a number of bugs with that version of the code, from what I recall the two most prominent were:
I took this approach to fixing it, I'm sure there were other alternatives. Ultimately longer term we will definitely be supporting any combination of custom permalinks. In this thread I made a suggestion of how we could go about doing that. But because it's a wider touching solution we went with this direction to help get 0.4 out the door. |
I just changed my permalink structure to include the date but looks like it's not working: links in the homepage have the right formate yyyy/mm/dd/title but when clicking on them I get a 404 page.
This happens both with posts published before and after the change in the permalink format.
If you want to test:
http://codeclimber-ghost.azurewebsites.net/
The text was updated successfully, but these errors were encountered: