-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper updates for Tag Pages #2112
Comments
Raising my hand here :) |
Down to the letter, exactly what I was going to suggest. So... +1 |
@ErisDS Just to be sure: Isn't the last example supposed to read |
Submitted the PR under the assumption that the second example was supposed to read:
|
fixes TryGhost#2112 refs TryGhost#1833 - modified config.urlFor to handle tag pages - modified {{#tags}} handlebars helper to autolink to tag pages. Additional autolink="false" parameter can be used to deactivate autolinking - modified url handlebars helper to handle tags - added isTag function to schema - added unit test for additional urlFor functionality - added unit test for {{#tags}} helper modifications - added unit test for url handlebards helper
You all forgot about "
:) |
@Venomen What did we forget? |
""""""""" |
I believe @Venomen is referring to the fact that both of our example snippets have a missing quote mark. This is just an example and has no effect on the implementation. |
These changes require #2111 to make any sense, and will depend on changes to the
urlFor
function, so it is possibly worth considering #1833.Tag helper update for tag pages
Once the feature for tag pages exists, the
{{tags}}
helper can be updated to output tags in an a tag by default, with an option to turn this off.I propose the option could be:
{{tags autolink="false"}}
but would like some feedback from the community on thisUrl helper update for tag pages
Once the feature for tag pages exists, the
{{url}}
helper can be updated to support outputting URLs in the tag context.This means that if someone wants to create a customised list of tags, rather than using the
{{tags}}
helper, they can do so by doing something like:The text was updated successfully, but these errors were encountered: