Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session expiry error message is an arse #2171

Closed
ErisDS opened this issue Feb 10, 2014 · 0 comments · Fixed by #2190
Closed

Session expiry error message is an arse #2171

ErisDS opened this issue Feb 10, 2014 · 0 comments · Fixed by #2190
Assignees
@sebgie
Labels
bug [triage] something behaving unexpectedly
Milestone
0.4.2

Comments

@ErisDS
Copy link
Member

ErisDS commented Feb 10, 2014

Ghost's sessions last 12 hours. Some people keep the window open a lot lot longer than that. If they do, their session goes away and when they go to save they get an unhelpful error message which just says 'Unknown Error'.

It would be great to upgrade that message to say something sensible like 'Oops, you're not logged in'.
@ErisDS ErisDS added this to the 0.5 milestone Feb 10, 2014
@ErisDS ErisDS added the bug label Feb 10, 2014
@ErisDS ErisDS mentioned this issue Feb 10, 2014
Closed
This was referenced Feb 13, 2014
Closed
Closed
@sebgie sebgie mentioned this issue Feb 13, 2014
Merged
sebgie added a commit to sebgie/Ghost that referenced this issue Feb 14, 2014
@sebgie
Make session expiry less arsey
d3c641e 
closes TryGhost#2171
- added authentication middleware
- removed authentication from routes
- moved authentication before CSRF validation
- moved caching rules before authentication
- changed/added test
@JohnONolan JohnONolan mentioned this issue Mar 6, 2014
Closed
@ErisDS ErisDS modified the milestones: 0.4.2, 0.5 Mar 10, 2014
@mdno mdno mentioned this issue Jan 9, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 9, 2023
Open
@fooiskandar fooiskandar mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebgie sebgie

Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
0.4.2
Development

Successfully merging a pull request may close this issue.

Make session expiry less arsey sebgie/Ghost
2 participants
@ErisDS @sebgie