Call to Action! Functional Tests

[ErisDS]

In /core/test/functional/admin/ we have a set of functional tests using Casper.js to visit the admin UI and test it out.

However, quite a lot of functionality is not properly tested.

Here are some areas that need tests (there are likely more). I would love to see PRs adding tests, even if it's just a single addition!

• General
  • main menu navigation
  • top left user menu navigation
• Content screen
  • left column
    • title
    • Draft / page / published label
    • featured star
    • green add new post button
  • right column
    • written / published by text & author name
    • edit post icon
    • post settings menu
    • delete modal
• Editor screen
  • image uploads
  • markdown modal
  • tag menu
  • post settings menu
  • delete modal
  • publish button
• Settings screen
  • image upload modals
  • form filling

It would be really really really good to get a bit more coverage to help with the ember migration

[m-tse]

Hey @ErisDS I've coded up a functional test for settings/image upload modals, first commit/pull requeset! I got a

remote: Permission to TryGhost/Ghost.git denied to mattse.
fatal: unable to access 'https://github.com/TryGhost/Ghost/': The requested URL returned error: 403

when I tried to push, I guess I need permission first.

[halfdan]

@MATTSE You need to push to your own fork and create a pull request. A read of our Git Workflow should help you to get this working :)

[AnneTheAgile]

hi! I'm looking around to see if there's something I can do. I just read about Mocha which sounds really great and I'd like to give it a whirl, so I referenced that in
Performance tests · Issue #1392

Related to that issue and this one, I cannot see that you have a public CI / Travis / build server that runs tests? Is there one running somewhere already or can that be gotten for free through Github? (Sorry if I am naive?!)
//AnneTheAgile

[halfdan]

@AnneTheAgile Hello there. We have a public CI (see https://travis-ci.org/TryGhost/Ghost/builds) that runs all our tests.

[AnneTheAgile]

@halfdan , ty that's wonderful!

[ErisDS]

FYI you can access this by clicking the button in the readme which displays on https://github.com/TryGhost/Ghost and shows the status of the build. This is pretty common on GitHub :)

[jaswilli]

I meant to add this comment after the last PR but forgot...

Just as a point of reference, I went through the list in the first comment and I believe every bullet now has test coverage.

[AnneTheAgile]

@ErisDS , thank you for the Github-fu tip about CI!
@jaswilli , thank you for reporting the status, it did seem like some items were done.
Should this ticket be closed then, and possibly a new one written to describe any missing items?

[ErisDS]

I think this is pretty much ready to close yes, however I believe the markdown modal isn't tested currently, although I may be wrong.

If we can go back through the list one more time and double check that everything has coverage that'd be great.

[AnneTheAgile]

I am stepping out right now, but if it is not trivial for one of you checking the list for you might be an easy way to get my feet wet. I can write up which test is which one on the list.

[jaswilli]

@ErisDS - good catch, the markdown modal wasn't covered. Incoming PR with that test.