-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flashes / notifications in Backbone #37
Comments
Need to wait until backbone is present. Currently the {{>flashes}} is compiled on pageload using pre-existing data. Saving, editing, etc is done async though. |
Where are we on this, and can it be pushed to 0.3? |
Working on this, expect a PR today - tomorrow. |
Because notifications will be async, and client generated, a couple of questions:
|
Notifications should have multiple states - passive, or persistent. Passive should disappear on the next pageload or user action, persistent should remain until manually dismissed by the user, with the "x". Eg:
Multiple persistent notifications should stack, until dismissed. There may be some UI / display issues with this. I'm thinking about a "notifications" wrapper that might solve a few problems, but for now let's just get it working functionally and then see here we are. |
I've added a div just after the |
Just an update. Passive notifications are working perfectly. Working on persistent ones. Basically I need to replace the |
Please resubmit this PR against the 'notifications' branch. Apologies I realise this will require some work due to the restructure :( |
Should close #37. There are persistent and passive notifications. Persistent ones: * are stored on `ghost.notifications`. * have an api made to add / remove them with client side ajax logic (probably not the most elegant, but works) * uses a modified `flashes.hbs` template * will only disappear if user closes the bar * stack Passive * added with backbone view / collection combo * stack * disappears on navigation and when user closes it
Should close TryGhost#37. There are persistent and passive notifications. Persistent ones: * are stored on `ghost.notifications`. * have an api made to add / remove them with client side ajax logic (probably not the most elegant, but works) * uses a modified `flashes.hbs` template * will only disappear if user closes the bar * stack Passive * added with backbone view / collection combo * stack * disappears on navigation and when user closes it
Now that we have Backbone in place across most of the admin app, we need to add in notifications. Currently, most operations do an alert.
Dynamic notifications should always exist at the same location in the DOM as the static ones (where the {{>flashes}} partial is included in default.hbs.
The dynamic notifications should also have/work with #142
The text was updated successfully, but these errors were encountered: