Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"=" in navigation bar url replaced with = #7826

Closed
kevingil opened this issue Jan 8, 2017 · 2 comments
Closed

"=" in navigation bar url replaced with = #7826

kevingil opened this issue Jan 8, 2017 · 2 comments
Assignees
Milestone

Comments

@kevingil
Copy link

kevingil commented Jan 8, 2017

Issue Summary

Using a link in the navigation bar that includes a = is replaced with =
This only happens in the navigation bar.
This is not a duplicate of issue #4627 as the url doesn't need to have double = and it is not translated to <marker>

edit:
& is being replaced with &amp

Steps to Reproduce

In http://your-domain.com/ghost/settings/navigation/ add a link that includes a =.

Technical details:

  • Ghost Version: 0.11.3
@kevinansfield kevinansfield self-assigned this Jan 9, 2017
@kevinansfield
Copy link
Member

Thanks @kevingil, I've confirmed the issue. Working on a fix, should hopefully be resolved the next release 😄

@kirrg001 kirrg001 added this to the 0.11.4 milestone Jan 10, 2017
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Jan 10, 2017
closes TryGhost#7826
- expose raw url value inside `{{navigation}}` helper
- modify `{{url}}` helper to urlencode values and mark as HTML-safe to avoid Handlebars additional HTML-escaping
kirrg001 pushed a commit that referenced this issue Jan 11, 2017
closes #7826

- expose raw url value inside `{{navigation}}` helper
- modify `{{url}}` helper to urlencode values and mark as HTML-safe to avoid Handlebars additional HTML-escaping
@kirrg001
Copy link
Contributor

closing. fixed via #7836

kirrg001 pushed a commit that referenced this issue Jan 17, 2017
closes #7826

- expose raw url value inside `{{navigation}}` helper
- modify `{{url}}` helper to urlencode values and mark as HTML-safe to avoid Handlebars additional HTML-escaping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants