Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Menu Bugs #788

Closed
JohnONolan opened this issue Sep 17, 2013 · 2 comments · Fixed by #808
Closed

Settings Menu Bugs #788

JohnONolan opened this issue Sep 17, 2013 · 2 comments · Fixed by #808
Assignees
@gotdibbs
Labels
bug [triage] something behaving unexpectedly
Milestone
0.3

Comments

@JohnONolan
Copy link
Member

Two issues with this:

1.) When the settings menu is open, the settings icon should be "active" (aka maintain its hover state)

2.) Opening any settings menu inside #publish-bar should first close all other settings menu inside #publish-bar (eg. the screenshot below should not be possible).

@gotdibbs I think you're probably most familiar with this stuff at the moment - would you mind? :)

image
@gotdibbs
Copy link
Contributor

Sure thing, assign away. I'll get to this tonight after the day job :)

@ghost ghost assigned gotdibbs Sep 17, 2013
@JohnONolan
Copy link
Member Author

Awesome - thank you :)

gotdibbs added a commit to gotdibbs/Ghost that referenced this issue Sep 18, 2013
@gotdibbs
Corrected settings menu bugs
ebe7053 
Fixes TryGhost#788

- Toggles now close all any other open toggles.
- Added .active class for post settings menu to ensure highlight stays
on settings icon/button until it is closed, not just on hover.
@gotdibbs gotdibbs mentioned this issue Sep 18, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gotdibbs gotdibbs

Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Corrected settings menu bugs gotdibbs/Ghost
2 participants
@JohnONolan @gotdibbs