Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable spell-check by default #8566

Closed
kevinansfield opened this issue Jun 12, 2017 · 8 comments · Fixed by TryGhost/Admin#747
Closed

Disable spell-check by default #8566

kevinansfield opened this issue Jun 12, 2017 · 8 comments · Fixed by TryGhost/Admin#747
Assignees
Labels
affects:admin Anything relating to Ghost Admin

Comments

@kevinansfield
Copy link
Member

Unfortunately the CodeMirror based spell-check isn't great and can be rather annoying when it's highlighting a lot of perfectly fine words, especially for non-english writers. As such we think it will be best to leave it disabled by default, allowing users to enable it when they want to review.

We're still actively looking for a better spell-check solution, especially one that will allow the native OS/browser spellcheck to function.

@kevinansfield kevinansfield added the affects:admin Anything relating to Ghost Admin label Jun 12, 2017
@kevinansfield kevinansfield self-assigned this Jun 12, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jun 15, 2017
closes TryGhost/Ghost#8566
- sets codemirror into "markdown" mode during initialisation
cobbspur pushed a commit to TryGhost/Admin that referenced this issue Jun 19, 2017
closes TryGhost/Ghost#8566
- sets codemirror into "markdown" mode during initialisation
@Wonderfall
Copy link

We're still actively looking for a better spell-check solution, especially one that will allow the native OS/browser spellcheck to function.

When will this be possible? This is the only thing I miss from Ghost 0.x. I write in french, and most of my articles reach more than 3000 words. It's painful to correct (I have to copy/paste my article in another editor so I can correct it...). The spellchecker toggle is only working in English, and I can't use my extension "Grammalecte".

@kevinansfield
Copy link
Member Author

When will this be possible?

When one is found ;-) At the moment it's not looking likely, browsers don't offer any API to access native spellcheck solutions so unless you are using plain text fields it's very difficult to have decent spellcheck. Any ideas, solutions, PRs, etc, are all very much welcome 😄

We're still planning to pick up our mobiledoc based editor (which does have native spellchecking) again at some point in the future but there's no timeline for that yet.

@jloh
Copy link
Member

jloh commented Oct 2, 2017

This currently makes authoring on mobile a real pain (on iOS at least) as Safari seems to think the post text box is code or something. None of the auto suggestions work. (Auto space after period etc).

@kevinansfield
Copy link
Member Author

@jloh that isn't related to this issue but more an problem with CodeMirror in general, those iOS issues won't be resolved until the Mobiledoc based editor returns

@angristan
Copy link

We're still actively looking for a better spell-check solution, especially one that will allow the native OS/browser spellcheck to function.

Any news on this? Using a custom spell-check software is one thing, but disabling the native one without any way to re-enable it is another...

@kevinansfield
Copy link
Member Author

@angristan you will need to look upstream on the CodeMirror repo for an answer to that. The Ghost core team isn't pursuing it's own spellcheck solution for the markdown editor, we are however working on an entirely new rich-text, block based editor which will have native spellcheck for rich-text areas

@angristan
Copy link

Thanks for your answer @kevinansfield

@dandv
Copy link

dandv commented Mar 9, 2018

#9311 should solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants