Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-label to close button in announcement bar #17169

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

paulknulst
Copy link
Contributor

@paulknulst paulknulst commented Jun 30, 2023

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • [ x Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!


🤖 Generated by Copilot at b27dc96

Added aria-label attributes to some elements in the Ghost admin interface to improve accessibility. Fixed some accessibility issues in the AnnouncementBar.js component.

added the aria-label attribute to the announcement bar close button to be a11y compliant

@daniellockyer daniellockyer changed the title add aria-label to close button in announcement bar Added aria-label to close button in announcement bar Jul 10, 2023
@daniellockyer daniellockyer merged commit bcf9b9b into TryGhost:main Jul 10, 2023
@daniellockyer
Copy link
Member

Thanks @paulknulst! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants