Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Header Card V2 feature flags #17263

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Added Header Card V2 feature flags #17263

merged 2 commits into from
Jul 10, 2023

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Jul 10, 2023

refs https://github.com/TryGhost/Product/issues/3508

  • added a feature flag for Header Cards that's being upgraded.

🤖 Generated by Copilot at 10ac1e4

This pull request adds a new feature flag headerUpgrade to the server and the admin settings, which allows the user to opt-in to a new header design. The feature flag is only available if the labs toggle is enabled.

refs TryGhost/Product#3508

- added a feature flag for Header Cards that's being upgraded.
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (ae8be7c) 66.76% compared to head (10ac1e4) 66.75%.

❗ Current head 10ac1e4 differs from pull request most recent head 18b898d. Consider uploading reports for the commit 18b898d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17263      +/-   ##
==========================================
- Coverage   66.76%   66.75%   -0.02%     
==========================================
  Files        1458     1458              
  Lines       81943    81944       +1     
  Branches    11021    11018       -3     
==========================================
- Hits        54709    54698      -11     
- Misses      26112    26125      +13     
+ Partials     1122     1121       -1     
Flag Coverage Δ
admin-tests 36.88% <ø> (+<0.01%) ⬆️
e2e-tests 81.32% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/admin/app/services/feature.js 81.35% <ø> (ø)
ghost/core/core/shared/labs.js 73.68% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronaldlangeveld ronaldlangeveld merged commit 4a07e85 into main Jul 10, 2023
@ronaldlangeveld ronaldlangeveld deleted the headerv2-flags branch July 10, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant