Improved comma tag completion on international keyboard layouts #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in issue #1475 - `String.localeCompare` can be more reliable for keys that do not relate to cursor movement - Adds a third key handler (`keypress`) that contains the character code rather than physical key - `COMMA` key constant no longer required (unless `,` char should be a constant?)
|
Closing due to failed tests. Oops! |
tigefa4u
pushed a commit
to tigefa4u/Ghost
that referenced
this pull request
Aug 3, 2022
closes TryGhost#12294 refs TryGhost/Admin#1707 - cache registered shortcuts and check KeyboardEvent before dispatching event to the root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in issue #1475
String.localeComparecan be more reliable for keys that do not relate to cursor movementkeypress) that contains the character code rather than physical keyCOMMAkey constant no longer required (unless,char should be a constant?)There don't appear to be any tagging ui tests yet, but I tried this manually using the Russian keyboard layout. The
бkey no longer submits tags, and the,key does despite being mapped to what would otherwise be a?key.Not sure how this fits in to the greater scope of issue #1463 but it fixes the problem for now.