-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added locale for urdu with translation files #18507 #18508
Conversation
Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏 |
@@ -37,7 +37,8 @@ const SUPPORTED_LOCALES = [ | |||
'sr', // Serbian | |||
'sv', // Swedish | |||
'tr', // Turkish | |||
'uk', // Ukrainian | |||
'uk', // Ukrainian, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error on this line - please remove the trailing comma
Hey @siddiqss , thanks for submitting these. I was sorry to see that they've not been merged in the last year. Can you please take a look at my comment about the extra comma, which is causing the tests to error? I used AI to check over the translations and identify no problems that would prevent a merge. If you are still interested in having these merged, it'd be super helpful if you could update your branch, resolve any conflicts, and add translations for the latest strings. Here are directions for the sync, if needed: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
@@ -37,7 +37,8 @@ const SUPPORTED_LOCALES = [ | |||
'sr', // Serbian | |||
'sv', // Swedish | |||
'tr', // Turkish | |||
'uk', // Ukrainian | |||
'uk', // Ukrainian, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'uk', // Ukrainian, | |
'uk', // Ukrainian |
Closing as duplicate of #21209 |
Updated the translations for urdu
yarn test:all
andyarn lint
)We appreciate your contribution!
🤖 Generated by Copilot at 3feebe1
This pull request adds Urdu language support for Ghost, a publishing platform. It does this by adding 'ur' to the list of supported locales in the
i18n
module and creating new files in theghost/i18n/locales/ur
directory that contain Urdu translations for the core features, themes, comments, portal, and signup form of Ghost.