Added tests to AdminX framework package #19022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19022 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 1251 1251
Lines 72611 72609 -2
Branches 9602 9601 -1
=======================================
- Hits 52840 52839 -1
- Misses 18989 18990 +1
+ Partials 782 780 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmraible
pushed a commit
to cmraible/Ghost
that referenced
this pull request
Nov 21, 2023
refs TryGhost/Product#4159 --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at 9e68f4d</samp> This pull request refactors several components in the `admin-x-settings` app to use common hooks from the `@tryghost/admin-x-framework` package, which reduces code duplication and improves consistency. It also updates the `package.json` file and adds unit tests for the `admin-x-framework` package, which improves the formatting, testing, and dependency management. Additionally, it makes some minor changes to the `hooks.ts`, `FrameworkProvider.tsx`, and `.eslintrc.cjs` files in the `admin-x-framework` package, which enhance the public API and the linting configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Product/issues/4159
🤖[deprecated] Generated by Copilot at 9e68f4d
This pull request refactors several components in the
admin-x-settingsapp to use common hooks from the@tryghost/admin-x-frameworkpackage, which reduces code duplication and improves consistency. It also updates thepackage.jsonfile and adds unit tests for theadmin-x-frameworkpackage, which improves the formatting, testing, and dependency management. Additionally, it makes some minor changes to thehooks.ts,FrameworkProvider.tsx, and.eslintrc.cjsfiles in theadmin-x-frameworkpackage, which enhance the public API and the linting configuration.