Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked post and page IDs in Ember Data errors #19035

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

cmraible
Copy link
Collaborator

no issue

  • The standard error message from Ember Data includes post/page ids in the error message
  • This causes Sentry to treat each instance as a unique issue and results in many duplicate issues for the same error
  • This change should mask the ids and allow Sentry to group the errors correctly

no issue

- The standard error message from Ember Data includes post/page ids in the error message
- This causes Sentry to treat each instance as a unique issue and results in many duplicate issues for the same error
- This change should mask the ids and allow Sentry to group the errors correctly
@cmraible cmraible merged commit c0e39af into TryGhost:main Nov 16, 2023
17 checks passed
cmraible added a commit to cmraible/Ghost that referenced this pull request Nov 21, 2023
no issue

- The standard error message from Ember Data includes post/page ids in
the error message
- This causes Sentry to treat each instance as a unique issue and
results in many duplicate issues for the same error
- This change should mask the ids and allow Sentry to group the errors
correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant