Fixed draft posts not autosaving without title #20774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs ENG-661 Fixes a long-standing issue where an outdated Lexical schema in the database triggered the unsaved changes confirmation dialog incorrectly. Implemented a secondary hidden Lexical instance that loads the state from the database, renders it, and uses this updated state to compare with the live editor's scratch. This ensures the unsaved changes prompt appears only when there are real changes from the user.
ronaldlangeveld
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20774 +/- ##
==========================================
- Coverage 73.87% 73.67% -0.20%
==========================================
Files 1266 1267 +1
Lines 74806 74980 +174
Branches 9978 9999 +21
==========================================
- Hits 55261 55244 -17
- Misses 18681 18881 +200
+ Partials 864 855 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ronaldlangeveld
added a commit
that referenced
this pull request
Aug 19, 2024
This reverts commit aad438b.
ronaldlangeveld
added a commit
that referenced
this pull request
Aug 19, 2024
kevinansfield
pushed a commit
to kevinansfield/Ghost
that referenced
this pull request
Aug 19, 2024
ref [ENG-661](https://linear.app/tryghost/issue/ENG-661/) ONC-253 - Reverts the revert of TryGhost@93cbb94 of the intial bug fix. - Updated hasDirtyAttributes logic to ensure the dirty state changes when typing a draft, despite not title. - Updated tests and added tests missing from the hasDirtyAttributes logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ENG-661 ONC-253