Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added one-time payments under "payments" for filtering #20807

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Aug 21, 2024

ref PLG-153

  • Scoped one-time payments (donation_event) under the "payments" category in the member activity feed filter.
  • Updated toggleEventType logic to ensure that toggling "payments" also toggles one-time payments when the tipsAndDonations feature is enabled.
  • Refactored event type handling into utility functions for easier testing.
  • Added unit tests for the new utility functions to ensure correct behaviour.
  • Added acceptance testing.

@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Aug 21, 2024
@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review August 21, 2024 10:58
@ronaldlangeveld ronaldlangeveld enabled auto-merge (squash) August 22, 2024 10:21
@ronaldlangeveld ronaldlangeveld enabled auto-merge (squash) August 22, 2024 10:22
@ronaldlangeveld ronaldlangeveld merged commit f2206fb into main Aug 22, 2024
18 checks passed
@ronaldlangeveld ronaldlangeveld deleted the added-donations-to-payment-cat branch August 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant