Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed member filtering for "Unsubscribed from newsletter" filters #20926

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Sep 5, 2024

ref https://linear.app/tryghost/issue/ENG-1466
ref https://linear.app/tryghost/issue/ENG-1484

  • Previously, filtering members with multiple "Unsubscribed from newsletter x" led to no filtering at all, all members were returned
  • This was caused by a bug in NQL, that is fixed in version 0.12.5, cf. commit
  • We're also removing the safeguard in the product around bulk deletion when multiple newsletter filters are in use, as the root problem has been fixed

ref https://linear.app/tryghost/issue/ENG-1466
ref https://linear.app/tryghost/issue/ENG-1484

- Previously, filtering members with multiple "Unsubscribed from newsletter x" led to no filtering at all, all members were returned
- This was caused by a bug in NQL, that is fixed in version 0.12.5, cf. [commit](TryGhost/NQL@dd18d1d)
- We're also removing the safeguard in the product around bulk deletion when multiple newsletter filters are in use, as the root problem has been fixed
@sagzy sagzy marked this pull request as draft September 5, 2024 16:37
@sagzy sagzy marked this pull request as ready for review September 5, 2024 16:43
@sagzy sagzy merged commit 430fbdb into main Sep 16, 2024
41 of 64 checks passed
@sagzy sagzy deleted the remove-safeguard-on-multiple-newsletters branch September 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant