🎨 wrap missing strings in portal #21042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
changed the title
|
Hey @cathysarisky thank you so so much for getting this done 🙏 . Would you mind making the change @sagzy suggested? Other than that this is good to go! 🎉 |
|
I'm wondering if I needed to bump the version of portal? I don't see the changes in a fresh Ghost install today... |
Lekler
added a commit
to Lekler/Ghost
that referenced
this pull request
Sep 23, 2024
Update pt-BR translation of portal.json Following commit TryGhost#21042 , the following updates were made: - Filled in 6 missing translations and made style corrections to existing translations to improve clarity and consistency.
sagzy
added a commit
that referenced
this pull request
Sep 24, 2024
sagzy
added a commit
that referenced
this pull request
Sep 24, 2024
Hey @cathysarisky, you're spot on that we need to bump Portal when we add new i18n strings to it. But our bad, not yours! :) I have now released a patch version of Portal (v2.43.2), which contains the new i18n strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!
Added sneaky missing translation wrapping, notably the elusive /year and /month strings. Also "Change Plan" and "Choose Plan" for upgrade situations.
I opted to include the slash in /year and /month , to give translators more options for interval presentation.