🌐⬅️add RTL to sodo-search & improved tests #21152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
changed the title
|
LGTM! Could you add some tests? Or I can, but we won't want to merge this until we have something covering it. |
Happy to, but I could use a little help thinking through that. Sorry, I'm a bit of a noob. :) |
|
Added tests - additional test for correct stemming in English, plus tested full word and stemmed retrieval with Arabic content. (Probably with horrible grammar.) |
cathysarisky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐Patch sodo-search to work with RTL languages also. -- Cathy Sarisky
Add dir prop, calculated by i18next from language (using the dir function)
Tweak a few styles to use me/ms/pe/ps instead of mr/ml/pr/pl
Suggestions for a better way to get rtl into the iframe html welcome. This is what I came up with.
Added updated test that checks that stemming works in English, and added tests for partial and full-word searching with RTL content.