Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and adjust various German translations in portal.json #21165

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

lsinger
Copy link
Contributor

@lsinger lsinger commented Sep 30, 2024

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

This PR adds and adjusts various German translations in portal.json. I'm a native speaker and have made adjustments to the best of my knowledge. As in #21163, the gender variations are a bit opinionated and I'm happy to discuss.

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from thewolfofallstreetz (Ghost forum): the (green) translations look good to me.

Only minor comment on 2: “(save {{highestYearlyDiscount}}%)”: “(jetzt {{highestYearlyDiscount}}% sparen)”

This string will show the highest discount of all the offered packages. So the discount will be “save up to” x%, but it could also be less.

To correctly express this in German you could say the following: (save up to {{highestYearlyDiscount}}%)": “(jetzt bis zu {{highestYearlyDiscount}}% sparen)”

My response: The string actually shows the price difference between monthly and yearly. So if you pick yearly, you’ll actually get the discount compared to monthly. I think "up to" is probably not needed here.

@lsinger, thanks for all your work to polish these! :)

@9larsons 9larsons merged commit 4679bbb into TryGhost:main Oct 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants