🌐 Portal translations - make additional errors translatable. #21190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
changed the title
9larsons
requested changes
Oct 2, 2024
9larsons
approved these changes
Oct 3, 2024
|
Looks great, thanks! I'd like to revisit some time why we need to load the special messages. We don't need to worry about that here. |
3 tasks
Lekler
added a commit
to Lekler/Ghost
that referenced
this pull request
Oct 7, 2024
Following commit TryGhost#21190, the following updates were made: - Filled missing translations and made style corrections to existing translations to improve clarity and consistency. Total new translations added: 29 entries filled. Existing translations improved: 7 entries updated for better consistency and clarity.
sagzy
pushed a commit
that referenced
this pull request
Oct 7, 2024
no issue - Following commit #21190, the following updates were made: - **Filled missing translations and made style corrections to existing translations to improve clarity and consistency.** - Total new translations added: 29 entries filled. - Existing translations improved: 7 entries updated for better consistency and clarity.
sagzy
pushed a commit
that referenced
this pull request
Oct 7, 2024
no issue - improved Vietnamese translations - improved i18n support for Portal error messages (cf. #21190)
tilak999
pushed a commit
to tilak999/ghost
that referenced
this pull request
Nov 20, 2024
no issue - Following commit TryGhost#21190, the following updates were made: - **Filled missing translations and made style corrections to existing translations to improve clarity and consistency.** - Total new translations added: 29 entries filled. - Existing translations improved: 7 entries updated for better consistency and clarity.
tilak999
pushed a commit
to tilak999/ghost
that referenced
this pull request
Nov 20, 2024
no issue - improved Vietnamese translations - improved i18n support for Portal error messages (cf. TryGhost#21190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose (some) Portal error strings for translations
💩This is a somewhat hacky (but test-passing and individual inspection passing) solution to the way Portal handles errors. Or rather, the half-dozen ways Portal handles errors.
Passing 't' around with context and state, and occasionally recreating it from the site object. Yes, I am also somewhat horrified, but a better implementation will need a major rewrite of Portal.
Addresses errors in both the popover React app and in the data-attributes.
There are probably more. Since Portal exposes raw API responses in some places, it's hard to enumerate everything that /might/ end up being client-facing, but at least I've gotten the ones that I've commonly seen.
Improvements very welcome.