🐛fixed error for tips on subdirectory sites #21250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
changed the title
sagzy
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Hey @cathysarisky!
Thanks for the fix 🙏 I can replicate the bug without the fix, and the bug is gone with your fix 🙌
Added one comment
tilak999
pushed a commit
to tilak999/ghost
that referenced
this pull request
Nov 20, 2024
…#21250) closes TryGhost#21123 - There was an error in the calculation of the site's url for sites setup as subdirectories (yoursite/blog instead of just yoursite/). - Fixed and tested with a manual build of portal. There's apparently a gap in test coverage here, as it passed both before and after...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21123
There was an error in the calculation of the site's url for sites setup as subdirectories (yoursite/blog instead of just yoursite/).
Fixed and tested with a manual build of portal. There's apparently a gap in test coverage here, as it passed both before and after...