Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New translations and bug fix on /month and /year #21267

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

cathysarisky
Copy link
Contributor

@cathysarisky cathysarisky commented Oct 9, 2024

No issue

Wrapped a missing /month and /year string. Should work with and without trials now.

Added a few additional translations for Japanese and French.

Adjusted German - some strings were too long to fit in the layout. Changed (the German equivalents of) "Start a X day free trial" to "Select", because the German is just not going to fit on the button.

@cathysarisky cathysarisky changed the title Client i18n fixes 🌐 Small collection of new translations for Portal Oct 9, 2024
@cathysarisky cathysarisky marked this pull request as ready for review October 9, 2024 15:02
@cathysarisky cathysarisky changed the title 🌐 Small collection of new translations for Portal 🌐 New translations and bug fix on /month and /year Oct 10, 2024
@mike182uk mike182uk merged commit 3a66200 into TryGhost:main Oct 16, 2024
21 checks passed
@mike182uk
Copy link
Member

Thanks for this @cathysarisky looks great 👌

Have merged in and should go out in the next release

dvdwinden pushed a commit that referenced this pull request Oct 24, 2024
No issue

Wrapped a missing /month and /year string. Should work with and without
trials now.

Added a few additional translations for Japanese and French.

Adjusted German - some strings were too long to fit in the layout.
Changed (the German equivalents of) "Start a X day free trial" to
"Select", because the German is just not going to fit on the button.
@cathysarisky cathysarisky deleted the client-i18n-fixes branch November 10, 2024 15:42
tilak999 pushed a commit to tilak999/ghost that referenced this pull request Nov 20, 2024
No issue

Wrapped a missing /month and /year string. Should work with and without
trials now.

Added a few additional translations for Japanese and French.

Adjusted German - some strings were too long to fit in the layout.
Changed (the German equivalents of) "Start a X day free trial" to
"Select", because the German is just not going to fit on the button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants